Gallardot commented on code in PR #17519:
URL:
https://github.com/apache/dolphinscheduler/pull/17519#discussion_r2435344149
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml:
##########
@@ -123,6 +137,9 @@ spec:
{{- include "dolphinscheduler.sharedStorage.volumeMount" . |
nindent 12 }}
{{- include "dolphinscheduler.fsFileResource.volumeMount" . |
nindent 12 }}
{{- include "dolphinscheduler.etcd.ssl.volumeMount" . | nindent 12
}}
+ {{- if .Values.worker.extraVolumeMounts }}
Review Comment:
`extraVolumeMounts` should be defined in `values.yaml`
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -583,6 +583,38 @@ worker:
# -- Update strategy
# ref:
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies
#
+ # -- Direct Secret Mounting
+ # Mount secrets directly as environment variables
+ # Single secret
+ envFromSecret: "git-sync-secret"
+
+ # Multiple secrets (advanced use cases)
+ # Use when you have variables distributed across different secrets
+ # envFromSecrets:
+ # - "git-sync-secret" # Git synchronization credentials
+ # - "database-secret" # Database connection details
+ # - "external-api-secret" # Third-party API keys
+
+ # -- Init Container for Advanced Processing
+ # Use when you need to transform, validate, or prepare configuration files
+ initContainers:
Review Comment:
I think `initContainers` should be disable as default.
```suggestion
initContainers: {}
```
The following examples can be retained, but they should be treated as
comments.
##########
deploy/kubernetes/dolphinscheduler/values.yaml:
##########
@@ -583,6 +583,38 @@ worker:
# -- Update strategy
# ref:
https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies
#
+ # -- Direct Secret Mounting
+ # Mount secrets directly as environment variables
+ # Single secret
+ envFromSecret: "git-sync-secret"
Review Comment:
```suggestion
envFromSecret: ""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
