ruanwenjun commented on code in PR #17402:
URL:
https://github.com/apache/dolphinscheduler/pull/17402#discussion_r2443637910
##########
docs/docs/en/guide/task/grpc.md:
##########
@@ -0,0 +1,57 @@
+# GRPC Node
+
+## Overview
+
+This node is used to execute gRPC tasks and supports checking gRPC status
codes, SSL/TLS, and other features.
+
+## Create Task
+
+- Click Project Management -> Project Name -> Workflow Definition, then click
the "Create Workflow" button to enter the DAG editing page:
+
+- Drag the <img src="../../../../img/tasks/icons/grpc.png" width="15"/> task
node from the toolbar to the canvas.
+
+## Task Parameters
+
+[//]: # (TODO: use the commented anchor below once our website template
supports this syntax)
+[//]: # (- For default parameter descriptions, please refer to
[DolphinScheduler Task Parameter Appendix](appendix.md#默认任务参数) under
`Default Task Parameters`.)
+
+- For default parameter descriptions, please refer to [DolphinScheduler Task
Parameter Appendix](appendix.md) under `Default Task Parameters`.
+
+| **Task Parameter** |
**Description**
|
+|--------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| gRPC Url | gRPC request URL, must use the `hostname:port`
format
|
+| gRPC Credential Type | Supports None (insecure), and client default
SSL/TLS credential types
|
+| Protobuf Definition | Protobuf code defining the service in the
`.proto` file, will be converted to JSON Descriptor when saved
|
+| Protobuf Definition JSON | Used for creating tasks via API, generated from
the above definition as [JSON
Descriptor](https://github.com/protobufjs/protobuf.js/#using-json-descriptors)
|
Review Comment:
Is this need to appear at docs? We don't have a task parameter named
`Protobuf Definition JSON`in the task form.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/GrpcParameters.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.grpc;
+
+import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
+import
org.apache.dolphinscheduler.plugin.task.grpc.protobufjs.GrpcDynamicService;
+import
org.apache.dolphinscheduler.plugin.task.grpc.protobufjs.JSONDescriptorHelper;
+
+import org.apache.commons.lang3.StringUtils;
+
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.protobuf.Descriptors;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
+public class GrpcParameters extends AbstractParameters {
+
+ private String url;
+
+ private GrpcCredentialType channelCredentialType =
GrpcCredentialType.INSECURE;
+
+ private String grpcServiceDefinition;
+
+ private String grpcServiceDefinitionJSON;
+
+ private String methodName;
+
+ private String message;
+
+ private GrpcCheckCondition grpcCheckCondition =
GrpcCheckCondition.STATUS_CODE_DEFAULT;
+
+ private String condition;
+
+ @JsonProperty("connectTimeout")
Review Comment:
```suggestion
@JsonProperty("connectTimeoutMs")
```
##########
.github/workflows/e2e.yml:
##########
@@ -192,6 +192,7 @@ jobs:
- name: Run Test
run: |
./mvnw -B -f dolphinscheduler-e2e/pom.xml -am \
+ -DtrimStackTrace=false \
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
