ruanwenjun commented on code in PR #17605:
URL:
https://github.com/apache/dolphinscheduler/pull/17605#discussion_r2465029005
##########
dolphinscheduler-task-executor/src/main/java/org/apache/dolphinscheduler/task/executor/log/TaskExecutorMDCUtils.java:
##########
@@ -25,26 +25,40 @@ public class TaskExecutorMDCUtils {
private static final String TASK_INSTANCE_ID_MDC_KEY = "taskInstanceId";
private static final String TASK_INSTANCE_LOG_FULL_PATH_MDC_KEY =
"taskInstanceLogFullPath";
+ private static final String WORKFLOW_INSTANCE_ID_MDC_KEY =
"workflowInstanceId";
public static MDCAutoClosable logWithMDC(final ITaskExecutor taskExecutor)
{
- return logWithMDC(taskExecutor.getId(),
taskExecutor.getTaskExecutionContext().getLogPath());
+ return logWithMDC(taskExecutor.getId(),
+ taskExecutor.getTaskExecutionContext().getLogPath(),
+ taskExecutor.getTaskExecutionContext() == null ? 0
Review Comment:
Why check null here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
