SbloodyS commented on code in PR #17607:
URL:
https://github.com/apache/dolphinscheduler/pull/17607#discussion_r2476483778
##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/ProjectE2ETest.java:
##########
@@ -69,6 +76,23 @@ void testAssignWorkerGroup() {
final ProjectPage page = new ProjectPage(browser);
page.assignWorkerGroup(project, workerGroup);
page.verifyAssignedWorkerGroup(project, workerGroup);
+
+ WorkerGroupPage workerGroupPage =
+ new
WorkerGroupPage(browser).goToNav(SecurityPage.class).goToTab(WorkerGroupPage.class);
+ WebDriverWaitFactory.createWebDriverWait(workerGroupPage.driver())
+
.until(ExpectedConditions.urlContains("/security/worker-group-manage"));
+ workerGroupPage.create(workerGroupTest);
+ Awaitility.await().atMost(Duration.ofMinutes(1)).untilAsserted(() -> {
+ browser.navigate().refresh();
+ assertThat(workerGroupPage.workerGroupList())
+ .as("workerGroup list should contain newly-created
workerGroup")
+ .extracting(WebElement::getText)
+ .anyMatch(it -> it.contains(workerGroupTest));
+ });
+
+ ProjectPage backToProjectPage = new
ProjectPage(browser).goToNav(ProjectPage.class);
+ backToProjectPage.assignWorkerGroup(project, workerGroupTest);
+ backToProjectPage.verifyAssignedWorkerGroup(project, workerGroupTest);
Review Comment:
It should be a new test case. And we should put test logic into `ProjectPage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
