ruanwenjun commented on code in PR #17645:
URL:
https://github.com/apache/dolphinscheduler/pull/17645#discussion_r2494221015
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/server/JdbcRegistryServer.java:
##########
@@ -303,12 +303,18 @@ private void doPurgeJdbcRegistryClientInDB(final
List<Long> jdbcRegistryClientId
return;
}
log.info("Begin to delete dead jdbcRegistryClient: {}",
jdbcRegistryClientIds);
-
jdbcRegistryDataRepository.deleteEphemeralDateByClientIds(jdbcRegistryClientIds);
+ deleteEphemeralDataByClientIds(jdbcRegistryClientIds);
Review Comment:
We should remove in this method, we only need to delete the
jdbcRegistryClient here.
```java
jdbcRegistryDataRepository.deleteEphemeralDateByClientIds(jdbcRegistryClientIds);
jdbcRegistryLockRepository.deleteByClientIds(jdbcRegistryClientIds);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
