yangyichao-mango commented on a change in pull request #3154:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3154#discussion_r453152439
##########
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/LoggerService.java
##########
@@ -75,7 +75,17 @@ public Result queryLog(int taskInstId, int skipLineNum, int
limit) {
logger.info("log host : {} , logPath : {} , logServer port :
{}",host,taskInstance.getLogPath(),Constants.RPC_PORT);
- String log = logClient.rollViewLog(host, Constants.RPC_PORT,
taskInstance.getLogPath(),skipLineNum,limit);
+ StringBuilder log = new StringBuilder();
+ if(skipLineNum == 0 ) {
Review comment:
```suggestion
StringBuilder log = new StringBuilder();
if (skipLineNum == 0) {
```
Hi,
Good job and thx a lot for your contribution, please configure the
`checkstyle.xml`[1] to IDE and it will help to format code.
[1] https://github.com/apache/incubator-dolphinscheduler/tree/dev/style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
