github-advanced-security[bot] commented on code in PR #17677:
URL:
https://github.com/apache/dolphinscheduler/pull/17677#discussion_r2533565963
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterServerLoadProtectionConfig.java:
##########
@@ -28,4 +28,6 @@
private int maxConcurrentWorkflowInstances = Integer.MAX_VALUE;
+ // Add data basedir disk usage threshold but set to 1.0 (100%) to
effectively disable the check
+ protected double maxDataBasedirDiskUsagePercentageThresholds = 1.0;
Review Comment:
## Missing Override annotation
This method overrides
[BaseServerLoadProtectionConfig.getMaxDataBasedirDiskUsagePercentageThresholds](1);
it is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5586)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterServerLoadProtectionConfig.java:
##########
@@ -28,4 +28,6 @@
private int maxConcurrentWorkflowInstances = Integer.MAX_VALUE;
+ // Add data basedir disk usage threshold but set to 1.0 (100%) to
effectively disable the check
+ protected double maxDataBasedirDiskUsagePercentageThresholds = 1.0;
Review Comment:
## Field masks field in super class
This field shadows another field called
[maxDataBasedirDiskUsagePercentageThresholds](1) in a superclass.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5584)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
