CalvinKirs commented on a change in pull request #3180:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3180#discussion_r453177400
##########
File path:
dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/runner/AlertSender.java
##########
@@ -78,17 +78,17 @@ public void run() {
AlertInfo alertInfo = new AlertInfo();
alertInfo.setAlertData(alertData);
- alertInfo.addProp("receivers", receviersList);
+ alertInfo.addProp("receivers", receiversList);
AlertPlugin emailPlugin =
pluginManager.findOne(Constants.PLUGIN_DEFAULT_EMAIL_ID);
retMaps = emailPlugin.process(alertInfo);
if (retMaps == null) {
alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE, "alert
send error", alert.getId());
- logger.info("alert send error : return value is null");
+ logger.error("alert send error : return value is null");
} else if
(!Boolean.parseBoolean(String.valueOf(retMaps.get(Constants.STATUS)))) {
alertDao.updateAlert(AlertStatus.EXECUTION_FAILURE,
String.valueOf(retMaps.get(Constants.MESSAGE)), alert.getId());
- logger.info("alert send error : {}",
retMaps.get(Constants.MESSAGE));
+ logger.error("alert send error : {}",
retMaps.get(Constants.MESSAGE));
} else {
Review comment:
Looks good to me,This log level, please trouble confirm it again.
@dailidong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
