niumy0701 commented on issue #14877: URL: https://github.com/apache/dolphinscheduler/issues/14877#issuecomment-3556209596
> > > Hello, I have a question. Resource close will occur during task execution, so there shouldn't be any need to pay attention to it in the lifecycle of task plugins, such as sqltask. [@ruanwenjun](https://github.com/ruanwenjun) <img alt="Image" width="1587" height="1218" src="https://private-user-images.githubusercontent.com/65696095/508778998-4f99ba6d-9a7e-431b-ba1e-0b3bfdca3d17.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjIxMzc5MjIsIm5iZiI6MTc2MjEzNzYyMiwicGF0aCI6Ii82NTY5NjA5NS81MDg3Nzg5OTgtNGY5OWJhNmQtOWE3ZS00MzFiLWJhMWUtMGIzYmZkY2EzZDE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTAzVDAyNDAyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNhNzFlYjgwMGM0MTc0YTg0OWQwNDllOGNhNmE3YTZkYjc1ZWZjNmZjZWFmZmNmZGU1YzZjN2ZkMmE4ZGZiZDUmWC1BbXotU2lnbmVk SGVhZGVycz1ob3N0In0.MEJ393b7VYp8KaPwx-HvcFTgDdRHtYj2SfLCN24bFQQ"> > > > > > > We should close the resource in the task lifecycle method rather than in the task plugin, this can help to avoid resource leak problem. > > [@ruanwenjun](https://github.com/ruanwenjun) ok, Can we first add a close method to AbstractTask, and then implement the close method for the task plugin that needs to close the resource Considering plugin upgrade compatibility, make modifications based on the plugins that require resource closure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
