SbloodyS commented on code in PR #17531: URL: https://github.com/apache/dolphinscheduler/pull/17531#discussion_r2554507106
########## dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/SerialCommandMapper.xml: ########## @@ -0,0 +1,36 @@ +<?xml version="1.0" encoding="UTF-8" ?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN" "http://mybatis.org/dtd/mybatis-3-mapper.dtd"; > +<mapper namespace="org.apache.dolphinscheduler.dao.mapper.SerialCommandMapper"> + <sql id="baseSql"> + id, workflow_instance_id, workflow_definition_code, workflow_definition_version, command, state, create_time, update_time + </sql> + + <select id="fetchSerialCommands" resultType="org.apache.dolphinscheduler.dao.entity.SerialCommand"> + select + <include refid="baseSql"/> + from t_ds_serial_command + order by id asc + limit #{fetchSize} + </select> + + <select id="deleteByWorkflowInstanceId"> + delete from t_ds_serial_command where workflow_instance_id = #{workflowInstanceId} + </select> + +</mapper> Review Comment: ```suggestion </mapper> ``` ########## dolphinscheduler-dao/src/main/resources/sql/upgrade/3.4.0_schema/mysql/dolphinscheduler_dml.sql: ########## @@ -15,4 +15,4 @@ * limitations under the License. */ -UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; +UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; Review Comment: ```suggestion UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
