Copilot commented on code in PR #17730: URL: https://github.com/apache/dolphinscheduler/pull/17730#discussion_r2562477464
########## deploy/kubernetes/dolphinscheduler/Chart.yaml: ########## @@ -43,22 +43,16 @@ appVersion: 3.1.0 dependencies: - name: postgresql - version: 10.3.18 - # Due to a change in the Bitnami repo, https://charts.bitnami.com/bitnami was truncated only - # containing entries for the latest 6 months (from January 2022 on). - # This URL: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami - # contains the full 'index.yaml'. - # See detail here: https://github.com/bitnami/charts/issues/10833 - repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami + version: 17.0.1 Review Comment: Updating to PostgreSQL chart v17.0.1 introduces breaking changes that require updates to `values.yaml` and `templates/_helpers.tpl`: 1. **Configuration parameters**: The chart uses a new schema where `postgresqlUsername`, `postgresqlPassword`, and `postgresqlDatabase` should be changed to `auth.username`, `auth.password`, and `auth.database` in values.yaml (lines 60-64). 2. **Secret key names**: The password secret key changed from `postgresql-password` to `password`. The template reference at `templates/_helpers.tpl:173` needs to be updated accordingly. 3. **Service name**: The default PostgreSQL service name format may have changed, potentially affecting the connection string at `templates/_helpers.tpl:154`. Without these updates, the PostgreSQL deployment will either fail or DolphinScheduler pods will be unable to connect to the database. Consider updating to an intermediate chart version first, or ensure all necessary configuration updates are included in this PR. ```suggestion version: 12.1.5 ``` ########## deploy/kubernetes/dolphinscheduler/Chart.yaml: ########## @@ -43,22 +43,16 @@ appVersion: 3.1.0 dependencies: - name: postgresql - version: 10.3.18 - # Due to a change in the Bitnami repo, https://charts.bitnami.com/bitnami was truncated only - # containing entries for the latest 6 months (from January 2022 on). - # This URL: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami - # contains the full 'index.yaml'. - # See detail here: https://github.com/bitnami/charts/issues/10833 - repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami + version: 17.0.1 + repository: https://charts.bitnami.com/bitnami condition: postgresql.enabled - name: zookeeper - version: 11.4.11 - # Same as above. - repository: https://raw.githubusercontent.com/bitnami/charts/archive-full-index/bitnami + version: 13.8.8 Review Comment: The Zookeeper chart version 13.8.8 may have renamed configuration parameters. Notably, `fourlwCommandsWhitelist` was changed to `fourlwCommandsAllowlist` in Bitnami Zookeeper chart v12.x and above to use more inclusive language. The values.yaml file should be checked and updated to use the correct parameter name compatible with chart version 13.8.8 to avoid configuration issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
