ruanwenjun commented on code in PR #17799:
URL:
https://github.com/apache/dolphinscheduler/pull/17799#discussion_r2623452713
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProjectWorkerGroupRelationServiceImpl.java:
##########
@@ -94,7 +94,25 @@ public Result assignWorkerGroupsToProject(User loginUser,
Long projectCode, List
return result;
}
+ Project project = projectMapper.queryByCode(projectCode);
+ if (Objects.isNull(project)) {
+ putMsg(result, Status.PROJECT_NOT_EXIST);
+ return result;
+ }
+
if (CollectionUtils.isEmpty(workerGroups)) {
+ Set<String> projectWorkerGroupNames =
+
projectWorkerGroupDao.queryAssignedWorkerGroupNamesByProjectCode(projectCode);
+ if (CollectionUtils.isNotEmpty(projectWorkerGroupNames)) {
+ Set<String> usedWorkerGroups = getAllUsedWorkerGroups(project);
+ if (CollectionUtils.isNotEmpty(usedWorkerGroups)) {
+ Set<String> usedInProject =
SetUtils.intersection(usedWorkerGroups, projectWorkerGroupNames);
+ if (!usedInProject.isEmpty()) {
+ throw new
ServiceException(Status.USED_WORKER_GROUP_EXISTS, usedInProject);
+ }
+ }
Review Comment:
For modification operations on projects, we should acquire project row
locks. All project-related operations and modification/creation actions for
workflows/task definitions within the project require acquiring row locks
first? This may be a long-term solution to avoid currently problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
