njnu-seafish commented on code in PR #17821:
URL:
https://github.com/apache/dolphinscheduler/pull/17821#discussion_r2681026295
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/WorkflowEventBusFireWorker.java:
##########
@@ -128,6 +131,19 @@ private void doFireSingleWorkflowEventBus(final
IWorkflowExecutionRunnable workf
ThreadUtils.sleep(5_000);
return;
}
+
+ // If task initializeTaskExecutionContext before dispatch is
failed
+ // construct and publish a dedicated TaskFatalLifecycleEvent
+ // so that the event will be handled by
TaskFatalLifecycleEventHandler
Review Comment:
> OK, I will remove it. Mainly because I noticed you previously added
explanatory comments at key points.
// If the database connection is failed, do not remove the
event from the event bus
// so that the event can be fired again when the database
connection is recovered
if (ExceptionUtils.isDatabaseConnectedFailedException(ex)) {
workflowEventBus.publish(lifecycleEvent);
ThreadUtils.sleep(5_000);
return;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
