Ujwalsingh-190 commented on code in PR #17888:
URL:
https://github.com/apache/dolphinscheduler/pull/17888#discussion_r2708347482
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java:
##########
@@ -248,10 +249,21 @@ public static String findValue(JsonNode jsonNode, String
fieldName) {
* @return json to map
*/
public static Map<String, String> toMap(String json) {
- return parseObject(json, new TypeReference<Map<String, String>>() {
+ Map<String, Object> map = parseObject(json, new
TypeReference<Map<String, Object>>() {
Review Comment:
Thank you for the review and suggestion. I understand the concern about
modifying this common utility method. I will revert this change and move the
parsing logic to the upper layer where it is needed. I’ll update the PR
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
