ruanwenjun commented on code in PR #17887:
URL:
https://github.com/apache/dolphinscheduler/pull/17887#discussion_r2712848653
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -428,6 +428,10 @@ private List<WorkflowTaskLineage>
generateWorkflowLineageList(List<TaskDefinitio
.parseObject(taskDefinitionLog.getTaskParams(),
DependentParameters.class)
.getDependence().getDependTaskList()) {
for (DependentItem dependentItem :
dependentTaskModel.getDependItemList()) {
+ // A Dependent node cannot rely on itself workflow
+ if (dependentItem.getDefinitionCode() ==
workflowDefinitionCode) {
+ throw new
ServiceException(Status.WORKFLOW_NODE_HAS_CYCLE);
+ }
Review Comment:
@Mrhs121 So we should not do any restrictions here, as there may be
scenarios where the current workflow depends on the previous day's operations?
It might be better to let users control all of this themselves.
So this PR only fix the lineage cycle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
