SbloodyS commented on code in PR #17914: URL: https://github.com/apache/dolphinscheduler/pull/17914#discussion_r2739577217
########## docs/docs/en/contribute/development-environment-setup.md: ########## @@ -54,6 +54,27 @@ pre-commit install Now, every time you commit your code, `pre-commit` will automatically run `Spotless` to check the code style and formatting. +### Frontend Code Style + +DolphinScheduler uses `pnpm` to check and automatically fix frontend code style and formatting issues. +First, navigate to the frontend project directory: + +```shell +cd dolphinscheduler-ui +``` + +Then, run `pnpm run lint` to check and fix frontend code style and formatting issues: + +```shell +pnpm run lint +``` + +Finally, you can run `pnpm run build:prod` to perform a full TypeScript type check, ensuring that only type-safe code is committed. Review Comment: ```suggestion ``` We don't need this since `pnpm run lint` is enough. ########## docs/docs/zh/contribute/development-environment-setup.md: ########## @@ -51,6 +51,27 @@ pre-commit install 现在，每次您提交代码时，`pre-commit`都会自动运行`Spotless`来检查代码风格和格式。 +### 前端代码风格 + +DolphinScheduler使用`pnpm`检查并修复前端代码风格和格式问题。 +首先，进入前端项目文件夹： + +```shell +cd dolphinscheduler-ui +``` + +然后，使用`pnpm run lint`检查并修复前端代码风格和格式问题。 + +```shell +pnpm run lint +``` + +最后，可以运行`pnpm run build:prod`来执行完整的 TypeScript 类型检查，确保只有类型正确的代码才能被提交。 + +```shell +pnpm run build:prod +``` Review Comment: ```suggestion ``` ########## docs/docs/zh/contribute/development-environment-setup.md: ########## @@ -51,6 +51,27 @@ pre-commit install 现在，每次您提交代码时，`pre-commit`都会自动运行`Spotless`来检查代码风格和格式。 +### 前端代码风格 + +DolphinScheduler使用`pnpm`检查并修复前端代码风格和格式问题。 +首先，进入前端项目文件夹： + +```shell +cd dolphinscheduler-ui +``` + +然后，使用`pnpm run lint`检查并修复前端代码风格和格式问题。 + +```shell +pnpm run lint +``` + +最后，可以运行`pnpm run build:prod`来执行完整的 TypeScript 类型检查，确保只有类型正确的代码才能被提交。 Review Comment: ```suggestion ``` ########## docs/docs/en/contribute/development-environment-setup.md: ########## @@ -54,6 +54,27 @@ pre-commit install Now, every time you commit your code, `pre-commit` will automatically run `Spotless` to check the code style and formatting. +### Frontend Code Style + +DolphinScheduler uses `pnpm` to check and automatically fix frontend code style and formatting issues. +First, navigate to the frontend project directory: + +```shell +cd dolphinscheduler-ui +``` + +Then, run `pnpm run lint` to check and fix frontend code style and formatting issues: + +```shell +pnpm run lint +``` + +Finally, you can run `pnpm run build:prod` to perform a full TypeScript type check, ensuring that only type-safe code is committed. + +```shell +pnpm run build:prod +``` Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
