SbloodyS commented on code in PR #17909:
URL:
https://github.com/apache/dolphinscheduler/pull/17909#discussion_r2741444053
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java:
##########
@@ -114,6 +114,21 @@ public class FlinkParameters extends AbstractParameters {
*/
private String rawScript;
+ /**
+ * Shutdown on attached exit (-sae parameter)
+ *
+ * <p>When enabled, Flink CLI will attempt to shutdown the cluster when
the CLI
+ * terminates abruptly. This is only suitable for attached mode
(CLUSTER/LOCAL).
+ *
+ * <p>For APPLICATION mode, this should typically be disabled as the job
runs
+ * in detached mode on YARN.
+ *
+ * <p>Default: false (disabled for safety)
+ *
+ * @see FlinkArgsUtils#buildRunCommandLine
+ */
+ private Boolean shutdownOnAttachedExit;
Review Comment:
> I think that "idempotency check" deserves to be a future optimization
feature on its own. It’s probably better to keep it > out of this current PR so
we don't block the merge.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
