SbloodyS commented on code in PR #17939:
URL:
https://github.com/apache/dolphinscheduler/pull/17939#discussion_r2757906479
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/executor/plugin/condition/ConditionLogicTask.java:
##########
@@ -95,9 +95,11 @@ private DependResult calculateConditionResult() {
private DependResult getDependResultForItem(ConditionDependentItem item,
Map<Long, TaskInstance> taskInstanceMap) {
TaskInstance taskInstance = taskInstanceMap.get(item.getDepTaskCode());
if (taskInstance == null) {
- log.info("The depend item: {} has not completed yet",
DependResult.FAILED);
- log.info("The dependent result will be {}", DependResult.FAILED);
- return DependResult.FAILED;
+ // Dependent task not found – likely misconfigured task code
Review Comment:
I don't understand why this should be changed. The current implementation is
to put the task in a failed state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
