chris-fast commented on PR #17909: URL: https://github.com/apache/dolphinscheduler/pull/17909#issuecomment-3845809483
> @chris-fast Hi, I’ve reopened this PR as the PR is still required. The Flink plugin shouldn’t append default arguments like -sea internally. Plugins should stay neutral and avoid hard-coded runtime parameters. A better approach would be to expose a configurable input in the UI, allowing users to provide such arguments explicitly when needed. We don’t need to add a separate input field for every possible argument. Instead, we can provide a single generic input field that accepts a list of custom parameters like these. If the -sae parameter is set in the input box configuration, shouldn't the original default behavior of adding -sae be removed? That's my understanding—there should be no -sae by default. We don't need to worry about backward compatibility for this setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
