SbloodyS commented on code in PR #18020:
URL:
https://github.com/apache/dolphinscheduler/pull/18020#discussion_r2899839398
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java:
##########
@@ -213,12 +240,25 @@ public void setGroupId(int groupId) {
@Override
public boolean checkParameters() {
- return datasource != 0 && StringUtils.isNotEmpty(type) &&
StringUtils.isNotEmpty(sql);
+ if (datasource == 0 || StringUtils.isEmpty(type)) {
+ return false;
+ }
+ // support both inline sql and sql from resource file
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
