SbloodyS commented on code in PR #18036: URL: https://github.com/apache/dolphinscheduler/pull/18036#discussion_r2901169788
########## dolphinscheduler-dist/src/main/assembly/assembly-plugins.sh: ########## @@ -77,8 +77,20 @@ done # create symbolic link for standalone-server cd $BIN_DIR/standalone-server && ln -s ../tools/sql/sql sql +# remove macOS junk so Linux extraction is clean +find "$BIN_DIR" -name '._*' -delete +find "$BIN_DIR" -name '.DS_Store' -delete +if [ "$(uname -s)" = "Darwin" ]; then + xattr -cr "$BIN_DIR" +fi + # repack bin tar BIN_TAR_FILE_NAME=$(basename $BIN_TAR_FILE) -cd $DIST_DIR && tar -zcf $BIN_TAR_FILE_NAME apache-dolphinscheduler-*-bin +cd $DIST_DIR +if [ "$(uname -s)" = "Darwin" ]; then + COPYFILE_DISABLE=1 tar --no-xattrs -zcf $BIN_TAR_FILE_NAME apache-dolphinscheduler-*-bin +else + tar -zcf $BIN_TAR_FILE_NAME apache-dolphinscheduler-*-bin +fi Review Comment: This is still unaddressed. You should revert this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
