ruanwenjun commented on code in PR #18036:
URL:
https://github.com/apache/dolphinscheduler/pull/18036#discussion_r2922336827
##########
pom.xml:
##########
@@ -797,6 +797,28 @@
<artifactId>maven-dependency-plugin</artifactId>
<version>${maven-dependency-plugin.version}</version>
</plugin>
+ <!-- Remove macOS junk from each module's target so assembly picks
up clean output -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>3.1.0</version>
+ <executions>
+ <execution>
+ <id>clean-macos-junk</id>
+ <phase>package</phase>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <configuration>
+ <target>
+ <delete failonerror="false">
+ <fileset dir="${project.build.directory}"
includes="**/._*, **/.DS_Store, ._*, .DS_Store" />
+ </delete>
+ </target>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review Comment:
We don't need to add this, we use `fileSets` to collect the file, we already
exclude this
```
<exclude>**/.DS_Store</exclude>
<exclude>**/Thumbs.db</exclude>
```
##########
dolphinscheduler-dist/src/main/assembly/assembly-plugins.sh:
##########
@@ -77,8 +77,8 @@ done
# create symbolic link for standalone-server
cd $BIN_DIR/standalone-server && ln -s ../tools/sql/sql sql
-# repack bin tar
+# repack bin tar (exclude macOS junk so extraction on Linux is clean)
BIN_TAR_FILE_NAME=$(basename $BIN_TAR_FILE)
-cd $DIST_DIR && tar -zcf $BIN_TAR_FILE_NAME apache-dolphinscheduler-*-bin
+cd $DIST_DIR && tar -zcf $BIN_TAR_FILE_NAME --exclude='._*'
--exclude='.DS_Store' apache-dolphinscheduler-*-bin
Review Comment:
This is caused by you open the directory by finder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
