norrishuang commented on PR #18069: URL: https://github.com/apache/dolphinscheduler/pull/18069#issuecomment-4101759438
Thank you for the feedback @SbloodyS! I have enhanced the unit tests to provide comprehensive coverage of the EMR Serverless task plugin. The test suite now includes 15 test cases covering: - **Full job lifecycle**: job submission → state polling → success/failure/cancelled - **Exception handling**: submission failures, polling failures, null job run responses - **Cancel operation**: cancel running job, cancel with empty jobRunId edge case - **Failover recovery**: restore job run ID from appIds after worker restart - **Parameter validation**: missing required fields, invalid JSON input - **State mapping**: all final states → exit code mapping - **Application ID retrieval**: getApplicationIds() The tests use Mockito to mock `EmrServerlessClient`, following the same pattern as `AliyunServerlessSparkTaskTest` in the codebase. Since this plugin depends on AWS EMR Serverless, running actual e2e tests in the CI Docker environment would require AWS credentials and a running EMR Serverless application, which is not feasible in the standard CI setup. Commit: norrishuang/dolphinscheduler@44f43eb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
