njnu-seafish commented on code in PR #18063:
URL:
https://github.com/apache/dolphinscheduler/pull/18063#discussion_r3007111869
##########
dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/integration/cases/WorkflowStartTestCase.java:
##########
@@ -1778,4 +1779,45 @@ public void
testTaskRemainsSubmittedSuccess_with_noAvailableWorkerAndTimeoutDisa
// masterContainer.assertAllResourceReleased();
}
+ @Test
+ @DisplayName("Test start a workflow when timeout should trigger alert when
warningGroupId is set")
+ public void testWorkflowTimeout_WithAlertGroup_ShouldSendAlert() {
+ final String yaml =
"/it/start/workflow_with_workflow_timeout_alert.yaml";
+ final WorkflowTestCaseContext context =
workflowTestCaseContextFactory.initializeContextFromYaml(yaml);
Review Comment:
> The PR description says this change has no test coverage, but this commit
adds a new master integration test for workflow-timeout alerts. Please update
the PR description/verify section to reflect the added coverage (or remove the
statement about having no tests) so reviewers and release notes stay accurate.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
