This is an automated email from the ASF dual-hosted git repository.

zihaoxiang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 0cba7932bb [Improvement-18084][API] Address the inconsistent class 
comments in DataSourceService and DataSourceServiceImpl classes. (#18086)
0cba7932bb is described below

commit 0cba7932bb09353686cc6eda488dbeb91e3eb300
Author: njnu-seafish <[email protected]>
AuthorDate: Thu Apr 2 16:47:43 2026 +0800

    [Improvement-18084][API] Address the inconsistent class comments in 
DataSourceService and DataSourceServiceImpl classes. (#18086)
---
 .../api/controller/DataSourceController.java       | 70 ++++++++++----------
 .../api/service/DataSourceService.java             | 74 ++++++++++++---------
 .../api/service/impl/DataSourceServiceImpl.java    | 77 ++--------------------
 .../src/main/resources/i18n/messages.properties    |  1 +
 .../main/resources/i18n/messages_en_US.properties  |  1 +
 .../main/resources/i18n/messages_zh_CN.properties  |  1 +
 6 files changed, 86 insertions(+), 138 deletions(-)

diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
index 72b7b21c3e..6f643ab4b6 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
@@ -35,6 +35,7 @@ import org.apache.dolphinscheduler.api.audit.OperatorLog;
 import org.apache.dolphinscheduler.api.audit.enums.AuditType;
 import org.apache.dolphinscheduler.api.enums.Status;
 import org.apache.dolphinscheduler.api.exceptions.ApiException;
+import org.apache.dolphinscheduler.api.exceptions.ServiceException;
 import org.apache.dolphinscheduler.api.service.DataSourceService;
 import org.apache.dolphinscheduler.api.utils.PageInfo;
 import org.apache.dolphinscheduler.api.utils.Result;
@@ -83,12 +84,13 @@ public class DataSourceController extends BaseController {
     private DataSourceService dataSourceService;
 
     /**
-     * create data source
+     * create a new data source
      *
      * @param loginUser login user
      * @param jsonStr   datasource param
      *                  example: 
{"type":"MYSQL","name":"txx","note":"","host":"localhost","port":3306,"principal":"","javaSecurityKrb5Conf":"","loginUserKeytabUsername":"","loginUserKeytabPath":"","userName":"root","password":"xxx","database":"ds","connectType":"","other":{"serverTimezone":"GMT-8"},"id":2}
-     * @return create result code
+     * @return the created DataSource object
+     * @throws ServiceException if the data source name already exists or 
parameters are invalid
      */
     @Operation(summary = "createDataSource", description = 
"CREATE_DATA_SOURCE_NOTES")
     @PostMapping()
@@ -103,18 +105,19 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * updateWorkflowInstance data source
+     * update an existing data source
      *
      * @param loginUser login user
      * @param id        datasource id
      * @param jsonStr   datasource param
      *                  example: 
{"type":"MYSQL","name":"txx","note":"","host":"localhost","port":3306,"principal":"","javaSecurityKrb5Conf":"","loginUserKeytabUsername":"","loginUserKeytabPath":"","userName":"root","password":"xxx","database":"ds","connectType":"","other":{"serverTimezone":"GMT-8"},"id":2}
-     * @return update result code
+     * @return the updated DataSource object
+     * @throws ServiceException if the data source does not exist or 
parameters are invalid
      */
     @Operation(summary = "updateDataSource", description = 
"UPDATE_DATA_SOURCE_NOTES")
     @Parameters({
             @Parameter(name = "id", description = "DATA_SOURCE_ID", required = 
true, schema = @Schema(implementation = int.class)),
-            @Parameter(name = "dataSourceParam", description = 
"DATA_SOURCE_PARAM", required = true, schema = @Schema(implementation = 
BaseDataSourceParamDTO.class))
+            @Parameter(name = "jsonStr", description = "DATA_SOURCE_PARAM", 
required = true, schema = @Schema(implementation = 
BaseDataSourceParamDTO.class))
     })
     @PutMapping(value = "/{id}")
     @ResponseStatus(HttpStatus.OK)
@@ -200,19 +203,18 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * connect datasource
+     * test the connection to a data source
      *
-     * @param loginUser login user
      * @param jsonStr   datasource param
      *                  example: 
{"type":"MYSQL","name":"txx","note":"","host":"localhost","port":3306,"principal":"","javaSecurityKrb5Conf":"","loginUserKeytabUsername":"","loginUserKeytabPath":"","userName":"root","password":"xxx","database":"ds","connectType":"","other":{"serverTimezone":"GMT-8"},"id":2}
-     * @return connect result code
+     * @return {@code true} if the connection test was successful
+     * @throws ServiceException if the connection fails or parameters are 
invalid
      */
     @Operation(summary = "connectDataSource", description = 
"CONNECT_DATA_SOURCE_NOTES")
     @PostMapping(value = "/connect")
     @ResponseStatus(HttpStatus.OK)
     @ApiException(CONNECT_DATASOURCE_FAILURE)
-    public Result<Boolean> connectDataSource(@Parameter(hidden = true) 
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-                                             
@io.swagger.v3.oas.annotations.parameters.RequestBody(description = 
"dataSourceParam") @RequestBody String jsonStr) {
+    public Result<Boolean> 
connectDataSource(@io.swagger.v3.oas.annotations.parameters.RequestBody(description
 = "dataSourceParam") @RequestBody String jsonStr) {
         BaseDataSourceParamDTO dataSourceParam = 
DataSourceUtils.buildDatasourceParam(jsonStr);
         DataSourceUtils.checkDatasourceParam(dataSourceParam);
         ConnectionParam connectionParams = 
DataSourceUtils.buildConnectionParams(dataSourceParam);
@@ -221,11 +223,12 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * connection test
+     * test the connection to an existing data source
      *
      * @param loginUser login user
      * @param id data source id
-     * @return A Result wrapping {@code true} if the connection is successful; 
otherwise, throws an exception.
+     * @return {@code true} if the connection test was successful
+     * @throws ServiceException if the connection fails or the data source 
does not exist
      */
     @Operation(summary = "connectionTest", description = 
"CONNECT_DATA_SOURCE_TEST_NOTES")
     @Parameters({
@@ -245,7 +248,8 @@ public class DataSourceController extends BaseController {
      *
      * @param loginUser login user
      * @param id datasource id
-     * @return delete result
+     * @return {@code true} if the deletion was successful
+     * @throws ServiceException if the data source does not exist or if the 
user lacks permission
      */
     @Operation(summary = "deleteDataSource", description = 
"DELETE_DATA_SOURCE_NOTES")
     @Parameters({
@@ -262,11 +266,11 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * verify datasource name
+     * verify if a data source name is available
      *
-     * @param loginUser login user
      * @param name data source name
-     * @return true if data source name not exists, otherwise return false
+     * @return {@code true} if the name is available (does not exist)
+     * @throws ServiceException if the name already exists
      */
     @Operation(summary = "verifyDataSourceName", description = 
"VERIFY_DATA_SOURCE_NOTES")
     @Parameters({
@@ -275,18 +279,17 @@ public class DataSourceController extends BaseController {
     @GetMapping(value = "/verify-name")
     @ResponseStatus(HttpStatus.OK)
     @ApiException(VERIFY_DATASOURCE_NAME_FAILURE)
-    public Result<Boolean> verifyDataSourceName(@Parameter(hidden = true) 
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-                                                @RequestParam(value = "name") 
String name) {
+    public Result<Boolean> verifyDataSourceName(@RequestParam(value = "name") 
String name) {
         dataSourceService.verifyDataSourceName(name);
         return Result.success(true);
     }
 
     /**
-     * unauthorized datasource
+     * query the list of unauthorized data sources for a specific user
      *
      * @param loginUser login user
      * @param userId user id
-     * @return unauthorized data source result code
+     * @return a list of unauthorized DataSource objects
      */
     @Operation(summary = "unauthorizedDatasource", description = 
"UNAUTHORIZED_DATA_SOURCE_NOTES")
     @Parameters({
@@ -295,19 +298,19 @@ public class DataSourceController extends BaseController {
     @GetMapping(value = "/unauth-datasource")
     @ResponseStatus(HttpStatus.OK)
     @ApiException(UNAUTHORIZED_DATASOURCE)
-    public Result<Object> unAuthDatasource(@Parameter(hidden = true) 
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-                                           @RequestParam("userId") Integer 
userId) {
+    public Result<Object> getUnauthorizedDatasourceList(@Parameter(hidden = 
true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
+                                                        
@RequestParam("userId") Integer userId) {
 
         List<DataSource> unAuthDatasourceList = 
dataSourceService.unAuthDatasource(loginUser, userId);
         return Result.success(unAuthDatasourceList);
     }
 
     /**
-     * authorized datasource
+     * query the list of data sources authorized for a specific user
      *
      * @param loginUser login user
      * @param userId user id
-     * @return authorized result code
+     * @return a list of authorized DataSource objects
      */
     @Operation(summary = "authedDatasource", description = 
"AUTHORIZED_DATA_SOURCE_NOTES")
     @Parameters({
@@ -316,29 +319,28 @@ public class DataSourceController extends BaseController {
     @GetMapping(value = "/authed-datasource")
     @ResponseStatus(HttpStatus.OK)
     @ApiException(AUTHORIZED_DATA_SOURCE)
-    public Result<Object> authedDatasource(@Parameter(hidden = true) 
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
-                                           @RequestParam("userId") Integer 
userId) {
+    public Result<Object> getAuthorizedDatasourceList(@Parameter(hidden = 
true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
+                                                      @RequestParam("userId") 
Integer userId) {
         List<DataSource> authedDatasourceList = 
dataSourceService.authedDatasource(loginUser, userId);
         return Result.success(authedDatasourceList);
     }
 
     /**
-     * get user info
+     * check the active status of Kerberos authentication
      *
-     * @param loginUser login user
-     * @return user info data
+     * @return {@code true} if Kerberos is active and configured for HDFS; 
{@code false} otherwise
      */
-    @Operation(summary = "getKerberosStartupState", description = 
"GET_USER_INFO_NOTES")
+    @Operation(summary = "getKerberosStartupState", description = 
"GET_KERBEROS_STARTUP_STATE")
     @GetMapping(value = "/kerberos-startup-state")
     @ResponseStatus(HttpStatus.OK)
     @ApiException(KERBEROS_STARTUP_STATE)
-    public Result<Object> getKerberosStartupState(@Parameter(hidden = true) 
@RequestAttribute(value = Constants.SESSION_USER) User loginUser) {
+    public Result<Object> getKerberosStartupState() {
         // if upload resource is HDFS and kerberos startup is true , else false
         return success(Status.SUCCESS.getMsg(), 
CommonUtils.getKerberosStartupState());
     }
 
     /**
-     * Retrieves the list of tables within a specific database of a data 
source.
+     * query the list of tables within a specific database of a data source
      *
      * @param loginUser the current logged-in user (injected from session)
      * @param datasourceId the unique identifier of the data source
@@ -361,7 +363,7 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * Retrieves the column details (schema) for a specific table.
+     * query the column details (schema) for a specific table
      *
      * @param loginUser the current logged-in user (injected from session)
      * @param datasourceId the unique identifier of the data source
@@ -387,7 +389,7 @@ public class DataSourceController extends BaseController {
     }
 
     /**
-     * Retrieves the list of databases available in a specific data source.
+     * query the list of databases available in a specific data source
      *
      * @param loginUser the current logged-in user (injected from session)
      * @param datasourceId the unique identifier of the data source
diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
index 6e42666513..b7426ce557 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
@@ -29,33 +29,36 @@ import 
org.apache.dolphinscheduler.spi.params.base.ParamsOptions;
 import java.util.List;
 
 /**
- * data source service
+ * datasource service
  */
 public interface DataSourceService {
 
     /**
-     * create data source
+     * create a new datasource
      *
      * @param loginUser login user
-     * @param datasourceParam datasource parameter
-     * @return create result code
+     * @param datasourceParam datasource configuration DTO
+     * @return created {@link DataSource} entity (sensitive fields masked)
+     * @throws ServiceException if permission denied, security check fails, or 
connection test fails
      */
     DataSource createDataSource(User loginUser, BaseDataSourceParamDTO 
datasourceParam);
 
     /**
-     * updateWorkflowInstance datasource
+     * update datasource
      *
      * @param loginUser login user
-     * @param dataSourceParam data source params
-     * @return update result code
+     * @param dataSourceParam datasource params
+     * @return updated {@link DataSource} entity (sensitive fields masked)
+     * @throws ServiceException if permission denied, security check fails, or 
connection test fails
      */
     DataSource updateDataSource(User loginUser, BaseDataSourceParamDTO 
dataSourceParam);
 
     /**
-     * updateWorkflowInstance datasource
+     * query datasource
      *
+     * @param loginUser login user
      * @param id datasource id
-     * @return data source detail
+     * @return a {@link BaseDataSourceParamDTO} entity (sensitive fields 
masked)
      */
     BaseDataSourceParamDTO queryDataSource(int id, User loginUser);
 
@@ -66,7 +69,7 @@ public interface DataSourceService {
      * @param searchVal search value
      * @param pageNo    page number
      * @param pageSize  page size
-     * @return data source list page
+     * @return datasource list page
      */
     PageInfo<DataSource> queryDataSourceListPaging(User loginUser, String 
searchVal, Integer pageNo, Integer pageSize);
 
@@ -74,30 +77,37 @@ public interface DataSourceService {
      * query data resource list
      *
      * @param loginUser login user
-     * @param type      data source type
-     * @return data source list page
+     * @param type      datasource type
+     * @return datasource list
      */
     List<DataSource> queryDataSourceList(User loginUser, Integer type);
 
     /**
-     * verify datasource exists
+     * verify whether a datasource name already exists
+     * <p>
+     * If the name already exists, a {@link ServiceException} is thrown.
+     * If the name is available (does not exist), the method completes 
successfully without returning a value.
      *
-     * @param name      datasource name
-     * @return true if data datasource not exists, otherwise return false
+     * @param name the datasource name to verify
+     * @throws ServiceException if the datasource name already exists 
(Status.DATASOURCE_EXIST)
      */
     void verifyDataSourceName(String name);
 
     /**
-     * check connection
+     * check the connectivity of a datasource based on the provided type and 
parameters
+     * <p>
+     * This method attempts to establish a connection.
+     * - If the connection is successful, the method returns normally (void).
+     * - If the connection fails, a {@link ServiceException} is thrown.
      *
-     * @param type      data source type
-     * @param parameter data source parameters
-     * @return true if connect successfully, otherwise false
+     * @param type            the type of the datasource (e.g., MYSQL, 
POSTGRESQL)
+     * @param connectionParam the connection parameters containing host, port, 
credentials, etc.
+     * @throws ServiceException if the connection test fails 
(Status.CONNECTION_TEST_FAILURE)
      */
-    void checkConnection(DbType type, ConnectionParam parameter);
+    void checkConnection(DbType type, ConnectionParam connectionParam);
 
     /**
-     * Tests the connectivity of a specific data source.
+     * test the connectivity of a specific data source
      *
      * @param loginUser the current logged-in user (required for permission 
check)
      * @param id        the unique identifier of the data source to test
@@ -106,34 +116,34 @@ public interface DataSourceService {
     void connectionTest(User loginUser, int id);
 
     /**
-     * delete datasource
+     * delete a datasource by ID
      *
-     * @param loginUser    login user
-     * @param datasourceId data source id
-     * @return delete result code
+     * @param loginUser    the current logged-in user
+     * @param datasourceId the unique identifier of the datasource to delete
+     * @throws ServiceException if checks fail or deletion encounters an error
      */
     void delete(User loginUser, int datasourceId);
 
     /**
-     * unauthorized datasource
+     * query the list of unauthorized data sources for a specific user
      *
      * @param loginUser login user
      * @param userId    user id
-     * @return unauthed data source result code
+     * @return a list of {@link DataSource} objects that are available to be 
authorized to the target user
      */
     List<DataSource> unAuthDatasource(User loginUser, Integer userId);
 
     /**
-     * authorized datasource
+     * query the list of data sources authorized for a specific user
      *
      * @param loginUser login user
      * @param userId    user id
-     * @return authorized result code
+     * @return a list of {@link DataSource} objects that are authorized to the 
target user
      */
     List<DataSource> authedDatasource(User loginUser, Integer userId);
 
     /**
-     * Retrieves the list of tables from a specific database within a data 
source.
+     * query the list of tables from a specific database within a data source
      *
      * @param loginUser    the current logged-in user (required for permission 
check)
      * @param datasourceId the unique identifier of the data source
@@ -144,7 +154,7 @@ public interface DataSourceService {
     List<ParamsOptions> getTables(User loginUser, Integer datasourceId, String 
database);
 
     /**
-     * Retrieves the list of columns for a specific table in a data source.
+     * query the list of columns for a specific table in a data source
      *
      * @param loginUser    current logged-in user
      * @param datasourceId ID of the data source
@@ -156,7 +166,7 @@ public interface DataSourceService {
     List<ParamsOptions> getTableColumns(User loginUser, Integer datasourceId, 
String database, String tableName);
 
     /**
-     * Retrieves the list of databases (or schemas) available in a specific 
data source.
+     * query the list of databases (or schemas) available in a specific data 
source
      *
      * @param loginUser    current logged-in user
      * @param datasourceId ID of the data source
diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
index 2ac02cb50c..fbe01b2bc2 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
@@ -86,13 +86,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
     private static final String TABLE_NAME = "TABLE_NAME";
     private static final String COLUMN_NAME = "COLUMN_NAME";
 
-    /**
-     * create data source
-     *
-     * @param loginUser       login user
-     * @param datasourceParam datasource parameters
-     * @return create result code
-     */
     @Override
     public DataSource createDataSource(User loginUser, BaseDataSourceParamDTO 
datasourceParam) {
         DataSourceUtils.checkDatasourceParam(datasourceParam);
@@ -129,12 +122,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         }
     }
 
-    /**
-     * updateWorkflowInstance datasource
-     *
-     * @param loginUser login user
-     * @return update result code
-     */
     @Override
     public DataSource updateDataSource(User loginUser, BaseDataSourceParamDTO 
dataSourceParam) {
         DataSourceUtils.checkDatasourceParam(dataSourceParam);
@@ -188,12 +175,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         return queryDataSource != null && !queryDataSource.isEmpty();
     }
 
-    /**
-     * updateWorkflowInstance datasource
-     *
-     * @param id datasource id
-     * @return data source detail
-     */
     @Override
     public BaseDataSourceParamDTO queryDataSource(int id, User loginUser) {
         DataSource dataSource = dataSourceMapper.selectById(id);
@@ -202,7 +183,7 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
             throw new ServiceException(Status.RESOURCE_NOT_EXIST);
         }
 
-        if (!canOperatorPermissions(loginUser, new 
Object[]{dataSource.getId()}, AuthorizationType.DATASOURCE,
+        if (!canOperatorPermissions(loginUser, new Object[]{id}, 
AuthorizationType.DATASOURCE,
                 ApiFuncIdentificationConstant.DATASOURCE)) {
             throw new ServiceException(Status.USER_NO_OPERATION_PERM);
         }
@@ -218,15 +199,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         return baseDataSourceParamDTO;
     }
 
-    /**
-     * query datasource list by keyword
-     *
-     * @param loginUser login user
-     * @param searchVal search value
-     * @param pageNo page number
-     * @param pageSize page size
-     * @return data source list page
-     */
     @Override
     public PageInfo<DataSource> queryDataSourceListPaging(User loginUser, 
String searchVal, Integer pageNo,
                                                           Integer pageSize) {
@@ -272,13 +244,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         return Constants.XXXXXX;
     }
 
-    /**
-     * query data resource list
-     *
-     * @param loginUser login user
-     * @param type data source type
-     * @return data source list page
-     */
     @Override
     public List<DataSource> queryDataSourceList(User loginUser, Integer type) {
 
@@ -298,12 +263,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         return datasourceList;
     }
 
-    /**
-     * verify datasource exists
-     *
-     * @param name datasource name
-     * @return true if data datasource not exists, otherwise return false
-     */
     @Override
     public void verifyDataSourceName(String name) {
         List<DataSource> dataSourceList = 
dataSourceMapper.queryDataSourceByName(name);
@@ -312,14 +271,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         }
     }
 
-    /**
-     * check connection
-     *
-     * @param type            data source type
-     * @param connectionParam connectionParam
-     * @return true if connect successfully, otherwise false
-     * @return true if connect successfully, otherwise false
-     */
     @Override
     public void checkConnection(DbType type, ConnectionParam connectionParam) {
         DataSourceProcessor sshDataSourceProcessor = 
DataSourceUtils.getDatasourceProcessor(type);
@@ -347,36 +298,25 @@ public class DataSourceServiceImpl extends 
BaseServiceImpl implements DataSource
                 DataSourceUtils.buildConnectionParams(dataSource.getType(), 
dataSource.getConnectionParams()));
     }
 
-    /**
-     * delete datasource
-     *
-     * @param loginUser    login user
-     * @param datasourceId data source id
-     * @return delete result code
-     */
     @Override
     @Transactional
     public void delete(User loginUser, int datasourceId) {
         // query datasource by id
         DataSource dataSource = dataSourceMapper.selectById(datasourceId);
+
         if (dataSource == null) {
             throw new ServiceException(Status.RESOURCE_NOT_EXIST);
         }
-        if (!canOperatorPermissions(loginUser, new 
Object[]{dataSource.getId()}, AuthorizationType.DATASOURCE,
+
+        if (!canOperatorPermissions(loginUser, new Object[]{datasourceId}, 
AuthorizationType.DATASOURCE,
                 DATASOURCE_DELETE)) {
             throw new ServiceException(Status.USER_NO_OPERATION_PERM);
         }
+
         dataSourceMapper.deleteById(datasourceId);
         datasourceUserMapper.deleteByDatasourceId(datasourceId);
     }
 
-    /**
-     * unauthorized datasource
-     *
-     * @param loginUser login user
-     * @param userId user id
-     * @return unauthed data source result code
-     */
     @Override
     public List<DataSource> unAuthDatasource(User loginUser, Integer userId) {
         List<DataSource> datasourceList;
@@ -404,13 +344,6 @@ public class DataSourceServiceImpl extends BaseServiceImpl 
implements DataSource
         return resultList;
     }
 
-    /**
-     * authorized datasource
-     *
-     * @param loginUser login user
-     * @param userId user id
-     * @return authorized result code
-     */
     @Override
     public List<DataSource> authedDatasource(User loginUser, Integer userId) {
         List<DataSource> authedDatasourceList = 
dataSourceMapper.queryAuthedDatasource(userId);
diff --git a/dolphinscheduler-api/src/main/resources/i18n/messages.properties 
b/dolphinscheduler-api/src/main/resources/i18n/messages.properties
index 586a35c88c..379f9b0cfd 100644
--- a/dolphinscheduler-api/src/main/resources/i18n/messages.properties
+++ b/dolphinscheduler-api/src/main/resources/i18n/messages.properties
@@ -224,6 +224,7 @@ DELETE_DATA_SOURCE_NOTES=delete data source
 VERIFY_DATA_SOURCE_NOTES=verify data source
 UNAUTHORIZED_DATA_SOURCE_NOTES=unauthorized data source
 AUTHORIZED_DATA_SOURCE_NOTES=authorized data source
+GET_KERBEROS_STARTUP_STATE=get the Kerberos startup state
 GET_DATASOURCE_DATABASE_NOTES=get datasource databases
 GET_DATASOURCE_TABLES_NOTES=get datasource tables
 GET_DATASOURCE_TABLE_COLUMNS_NOTES=get datasource table columns
diff --git 
a/dolphinscheduler-api/src/main/resources/i18n/messages_en_US.properties 
b/dolphinscheduler-api/src/main/resources/i18n/messages_en_US.properties
index 075c8ca561..086dbc2694 100644
--- a/dolphinscheduler-api/src/main/resources/i18n/messages_en_US.properties
+++ b/dolphinscheduler-api/src/main/resources/i18n/messages_en_US.properties
@@ -257,6 +257,7 @@ DELETE_DATA_SOURCE_NOTES=delete data source
 VERIFY_DATA_SOURCE_NOTES=verify data source
 UNAUTHORIZED_DATA_SOURCE_NOTES=unauthorized data source
 AUTHORIZED_DATA_SOURCE_NOTES=authorized data source
+GET_KERBEROS_STARTUP_STATE=get the Kerberos startup state
 GET_DATASOURCE_DATABASE_NOTES=get datasource databases
 GET_DATASOURCE_TABLES_NOTES=get datasource tables
 GET_DATASOURCE_TABLE_COLUMNS_NOTES=get datasource table columns
diff --git 
a/dolphinscheduler-api/src/main/resources/i18n/messages_zh_CN.properties 
b/dolphinscheduler-api/src/main/resources/i18n/messages_zh_CN.properties
index b85daa0a11..f6a1bd01e4 100644
--- a/dolphinscheduler-api/src/main/resources/i18n/messages_zh_CN.properties
+++ b/dolphinscheduler-api/src/main/resources/i18n/messages_zh_CN.properties
@@ -256,6 +256,7 @@ DELETE_DATA_SOURCE_NOTES=\u5220\u9664\u6570\u636E\u6E90
 VERIFY_DATA_SOURCE_NOTES=\u9A8C\u8BC1\u6570\u636E\u6E90
 UNAUTHORIZED_DATA_SOURCE_NOTES=\u672A\u6388\u6743\u7684\u6570\u636E\u6E90
 AUTHORIZED_DATA_SOURCE_NOTES=\u6388\u6743\u7684\u6570\u636E\u6E90
+GET_KERBEROS_STARTUP_STATE=\u83B7\u53D6Kerberos\u542F\u52A8\u72B6\u6001
 GET_DATASOURCE_DATABASE_NOTES=\u83B7\u53D6\u6570\u636E\u6E90\u5E93\u5217\u8868
 GET_DATASOURCE_TABLES_NOTES=\u83B7\u53D6\u6570\u636E\u6E90\u8868\u5217\u8868
 
GET_DATASOURCE_TABLE_COLUMNS_NOTES=\u83B7\u53D6\u6570\u636E\u6E90\u8868\u5217\u540D

Reply via email to