This is an automated email from the ASF dual-hosted git repository.

zihaoxiang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new ff52988f31 [Improvement-18127][Master] Remove the redundant workflow 
completion check when handling workflow timeout events (#18128)
ff52988f31 is described below

commit ff52988f31887665dd9f2a0f896fc9324b0136ca
Author: njnu-seafish <[email protected]>
AuthorDate: Thu Apr 2 17:18:30 2026 +0800

    [Improvement-18127][Master] Remove the redundant workflow completion check 
when handling workflow timeout events (#18128)
---
 .../lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java    | 7 -------
 1 file changed, 7 deletions(-)

diff --git 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java
 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java
index 34e405125a..8e4b5ad424 100644
--- 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java
+++ 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/lifecycle/handler/WorkflowTimeoutLifecycleEventHandler.java
@@ -19,7 +19,6 @@ package 
org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.hand
 
 import org.apache.dolphinscheduler.dao.entity.WorkflowInstance;
 import org.apache.dolphinscheduler.server.master.engine.ILifecycleEventType;
-import 
org.apache.dolphinscheduler.server.master.engine.graph.IWorkflowExecutionGraph;
 import 
org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.WorkflowLifecycleEventType;
 import 
org.apache.dolphinscheduler.server.master.engine.workflow.lifecycle.event.WorkflowTimeoutLifecycleEvent;
 import 
org.apache.dolphinscheduler.server.master.engine.workflow.runnable.IWorkflowExecutionRunnable;
@@ -46,12 +45,6 @@ public class WorkflowTimeoutLifecycleEventHandler
     public void handle(final IWorkflowStateAction workflowStateAction,
                        final IWorkflowExecutionRunnable 
workflowExecutionRunnable,
                        final WorkflowTimeoutLifecycleEvent 
workflowTimeoutLifecycleEvent) {
-        final IWorkflowExecutionGraph workflowExecutionGraph = 
workflowExecutionRunnable.getWorkflowExecutionGraph();
-        if (workflowExecutionGraph.isAllTaskExecutionRunnableChainFinish()) {
-            // all the TaskExecutionRunnable chain in the graph is finish, 
means the workflow is already finished.
-            return;
-        }
-
         final WorkflowInstance workflowInstance = 
workflowExecutionRunnable.getWorkflowInstance();
         final boolean shouldSendAlert = workflowInstance.getWarningGroupId() 
!= null;
 

Reply via email to