github-advanced-security[bot] commented on code in PR #18230:
URL:
https://github.com/apache/dolphinscheduler/pull/18230#discussion_r3206790122
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UiPluginController.java:
##########
@@ -67,11 +68,10 @@
@GetMapping(value = "/query-by-type")
@ResponseStatus(HttpStatus.CREATED)
@ApiException(QUERY_PLUGINS_ERROR)
- public Result queryUiPluginsByType(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
- @RequestParam(value = "pluginType")
PluginType pluginType) {
-
- Map<String, Object> result =
uiPluginService.queryUiPluginsByType(pluginType);
- return returnDataList(result);
+ public Result<List<PluginDefine>> queryUiPluginsByType(@Parameter(hidden =
true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
Review Comment:
## CodeQL / Useless parameter
The parameter 'loginUser' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5775)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UiPluginController.java:
##########
@@ -81,11 +81,10 @@
@GetMapping(value = "/{id}")
@ResponseStatus(HttpStatus.CREATED)
@ApiException(QUERY_PLUGINS_ERROR)
- public Result queryUiPluginDetailById(@Parameter(hidden = true)
@RequestAttribute(value = Constants.SESSION_USER) User loginUser,
- @PathVariable("id") Integer
pluginId) {
-
- Map<String, Object> result =
uiPluginService.queryUiPluginDetailById(pluginId);
- return returnDataList(result);
+ public Result<PluginDefine> queryUiPluginDetailById(@Parameter(hidden =
true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
Review Comment:
## CodeQL / Useless parameter
The parameter 'loginUser' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/5774)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
