ruanwenjun opened a new pull request, #18240:
URL: https://github.com/apache/dolphinscheduler/pull/18240

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are 
happy that you want to help us improve DolphinScheduler! -->
   
   ## Was this PR generated or assisted by AI?
   
   YES, ops 4.7
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   WorkerGroupDispatcher#run consumed TaskDispatchableEventBus#take() which was 
annotated with @SneakyThrows, so an InterruptedException raised when the master 
shuts down (the dispatch thread is parked on the queue) was rethrown as a 
RuntimeException and surfaced with a full stack trace — alarming "thread died" 
noise during a perfectly graceful shutdown.
   
   Drop @SneakyThrows from take() so it declares InterruptedException, and let 
the dispatch loop catch it: re-set the interrupt flag, log a single info line, 
and return so the daemon thread exits cleanly.
   
   Also clamp the dispatch-retry waiting time to >= 1s so a freshly-counted 
failure does not immediately re-enqueue the task against the same unhealthy 
worker group.
   
   In addition, document how to run dolphinscheduler-master tests in the 
module's CLAUDE.md: no Docker required, watch out for stale JaCoCo classes, 
surefire forks 4 JVMs in parallel, and the trailing "kill self fork JVM ... 30 
seconds after System.exit(0)" line is a harmless warning.
   
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   (or)
   
   ## Pull Request Notice
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   If your pull request contains incompatible change, you should also add it to 
`docs/docs/en/guide/upgrade/incompatible.md`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to