ruanwenjun opened a new pull request, #18250: URL: https://github.com/apache/dolphinscheduler/pull/18250
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES, ops 4.7 ## Purpose of the pull request Tracking issue: #18249 Add the remaining query methods on ProjectDao and WorkflowDefinitionDao, and replace every direct ProjectMapper / WorkflowDefinitionMapper reference in dolphinscheduler-api with the corresponding Dao, so Mapper usage stays inside dolphinscheduler-dao.repository as documented in dolphinscheduler-dao/CLAUDE.md. Notes: - WorkflowDefinitionDao#queryByCode returns Optional<WorkflowDefinition> (Mapper returned a bare nullable WorkflowDefinition), so affected ServiceImpl call sites use .orElse(null) for behavior-preserving substitution. Test classes were migrated to mock the Dao instead of the Mapper; queryByCode stubs are wrapped with Optional.of / Optional.empty. - BaseDao#deleteById and BaseDao#updateById return boolean where the Mapper returned int; affected call sites in ProjectServiceImpl and ProjectServiceTest were adapted accordingly. selectBatchIds was replaced with the equivalent IDao#queryByIds. - ProcessServiceImpl in dolphinscheduler-service still depends on WorkflowDefinitionMapper and is out of scope for this commit; TaskDefinitionServiceImplTest keeps both a Dao and a Mapper mock to serve the two @InjectMocks targets it exercises. No production behavior changes; the Mapper interfaces themselves are untouched. ## Brief change log <!--*(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* --> ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
