ruanwenjun opened a new pull request, #18252:
URL: https://github.com/apache/dolphinscheduler/pull/18252
<!--Thanks very much for contributing to Apache DolphinScheduler, we are
happy that you want to help us improve DolphinScheduler! -->
## Was this PR generated or assisted by AI?
YES, ops 4.7
## Purpose of the pull request
Tracking issue: #18249
Expose the methods the api layer needs on TaskInstanceDao
(countTaskInstanceStateByProjectCodes, queryByWorkflowInstanceIdsAndTaskCodes,
queryTaskInstanceListPaging, queryStreamTaskInstanceListPaging) and replace
every direct TaskInstanceMapper reference in dolphinscheduler-api with the Dao,
so Mapper usage stays inside dolphinscheduler-dao.repository as documented in
dolphinscheduler-dao/CLAUDE.md.
Notes:
- selectById was replaced with the IDao#queryById equivalent. The Mapper's
queryByInstanceIdAndCode is exposed on the Dao as the more descriptive
queryByWorkflowInstanceIdAndTaskCode (already present); api callers were
updated to the new name.
- The Mapper's findValidTaskListByWorkflowInstanceId(id, Flag) is collapsed
on the Dao to queryValidTaskListByWorkflowInstanceId(id), which already
hard-codes Flag.YES. All current api callers passed Flag.YES so they drop the
argument.
- BaseDao#updateById returns boolean where the Mapper returned int; the
affected call site in TaskInstanceServiceImpl#forceTaskSuccess (int changedNum
= ...; if (changedNum <= 0) {...}) was refactored to boolean changed = ...; if
(!changed) {...}.
No production behavior changes; the Mapper interface itself is untouched.
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to
`docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
