ruanwenjun opened a new pull request, #18258: URL: https://github.com/apache/dolphinscheduler/pull/18258
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES, gpt5.5 ## Purpose of the pull request Encapsulate TenantMapper behind TenantDao so the api layer depends only on the repository abstraction. Add methods to TenantDao: queryDetailById (preserves the mapper's custom JOIN against t_ds_queue that returns queue_name / queue), queryTenantListByQueueId, queryTenantPaging, and existTenant (boolean instead of nullable Boolean via Boolean.TRUE.equals). Switch updateById / deleteById call sites in TenantServiceImpl from int to boolean using the IDao convention: <=0 becomes !success in the guard. The selectBatchIds call becomes queryByIds, and existTenant downstream checks drop the Boolean.TRUE.equals dance since the Dao returns primitive. Tracking issue: #18249 ## Brief change log <!--*(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* --> ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
