ruanwenjun opened a new pull request, #18261: URL: https://github.com/apache/dolphinscheduler/pull/18261
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! --> ## Was this PR generated or assisted by AI? YES, gpt 5.5 ## Purpose of the pull request Introduce AlertGroupDao and AccessTokenDao so the api layer depends only on the repository abstraction. The two mappers are bundled because UsersServiceImpl and ResourcePermissionCheckServiceImpl share both. AlertGroupDao preserves the mapper's custom ORDER BY update_time DESC in queryAllGroupList (cannot be replaced with IDao.queryAll). existGroupName returns primitive boolean via Boolean.TRUE.equals so callers drop the == Boolean.TRUE dance. AccessTokenDao renames mapper.selectAccessTokenPage to queryAccessTokenPage and mapper.deleteAccessTokenByUserId to deleteByUserId. updateById in AccessTokenServiceImpl switches from int to boolean so the guard becomes !success instead of i <= 0. AlertGroupControllerTest.clear() replaces the BaseMapper.delete(QueryWrapper) idiom with a queryAllGroupList stream + deleteById loop so the controller test can stop reaching into MyBatis-Plus internals. Tracking issue: #18249 ## Brief change log <!--*(for example:)* - *Add maven-checkstyle-plugin to root pom.xml* --> ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
