wcmolin opened a new pull request, #18268:
URL: https://github.com/apache/dolphinscheduler/pull/18268
## Was this PR generated or assisted by AI?
Yes
## Purpose of the pull request
Allow S3-compatible storage, such as self-hosted MinIO, to use a custom
region when `aws.s3.endpoint` is configured.
Previously, `AmazonS3ClientFactory` always called
`Regions.fromName(region)`, which rejected non-AWS region values before
building the S3 client. For custom S3 endpoints, the configured region should
be used as the signing region directly.
## Brief change log
- Use the raw configured S3 region when `aws.s3.endpoint` is configured.
- Keep the existing AWS region validation when no custom S3 endpoint is
configured.
- Add unit tests for custom endpoint region handling.
## Verify this pull request
This change added tests and can be verified as follows:
- Added `AmazonS3ClientFactoryTest` to verify custom regions are allowed
when an S3 endpoint is configured.
- Added test coverage to verify invalid custom regions are still rejected
when no endpoint is configured.
- Added test coverage to verify empty regions are rejected when an endpoint
is configured.
- Verified locally with:
`./mvnw -pl
dolphinscheduler-authentication/dolphinscheduler-aws-authentication test
-Dtest=AmazonS3ClientFactoryTest -DskipITs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
