ruanwenjun opened a new pull request, #18270:
URL: https://github.com/apache/dolphinscheduler/pull/18270

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are 
happy that you want to help us improve DolphinScheduler! -->
   
   ## Was this PR generated or assisted by AI?
   
   YES. The code change, verification, and PR description were assisted by 
OpenAI Codex.
   
   ## Purpose of the pull request
   
   Close #18269.
   
   `LogicFakeTask` is intended only for master integration tests, but it was 
compiled from production source sets and registered as a production task type. 
This pull request moves the fake task implementation and related plugin code to 
test scope so it is no longer packaged into production binaries.
   
   ## Brief change log
   
   - Move `LogicFakeTask`, `LogicFakeTaskPluginFactory`, 
`LogicFakeTaskChannel`, `LogicFakeTaskChannelFactory`, and 
`LogicFakeTaskParameters` into `dolphinscheduler-master` test sources.
   - Register the fake task channel from test scope with 
`@AutoService(TaskChannelFactory.class)`.
   - Add a regression test to verify production `TaskPluginManager` cannot load 
`LogicFakeTask`.
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - `./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api 
-Dtest=TaskPluginManagerTest -Djacoco.skip=true test`
   - `./mvnw -pl dolphinscheduler-master 
-Dtest=WorkflowStartBasicTestCase#testStartWorkflow_with_oneSuccessTask 
-Djacoco.skip=true clean test`
   
   ## Pull Request Notice
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   This pull request does not contain incompatible changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to