ruanwenjun commented on code in PR #18275:
URL:
https://github.com/apache/dolphinscheduler/pull/18275#discussion_r3274469120
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/src/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/server/JdbcRegistryServer.java:
##########
@@ -340,7 +340,7 @@ private void refreshClientsHeartbeat() {
}
JdbcRegistryClientHeartbeatDTO clone =
jdbcRegistryClientHeartbeatDTO.clone();
clone.setLastHeartbeatTime(now);
-
jdbcRegistryClientRepository.updateById(jdbcRegistryClientHeartbeatDTO);
+
jdbcRegistryClientRepository.upsert(jdbcRegistryClientHeartbeatDTO);
Review Comment:
It's better don't use upsert here, if the client heartbeat has been removed,
then we should shutdown, since the server might have been failovered by other
server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
