ruanwenjun opened a new pull request, #18279:
URL: https://github.com/apache/dolphinscheduler/pull/18279

   ## Was this PR generated or assisted by AI?
   
   YES. The implementation and tests were assisted by OpenAI Codex, then 
reviewed and verified locally.
   
   ## Purpose of the pull request
   
   Fixes #18276.
   
   Fix alert plugin instance permission checks so alert plugin instance APIs 
consistently validate the current user's operation-level permission before 
returning alert plugin instance data.
   
   ## Brief change log
   
   - Pass the login user into alert plugin instance list and duplicate-name 
check service APIs.
   - Add operation-level permission checks for alert plugin instance list, page 
query, and name verification flows.
   - Keep alert plugin instance checks operation-scoped without deriving fake 
per-instance resource permissions from alert plugin definitions.
   - Add service and controller tests for the permission checks.
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - `./mvnw -pl dolphinscheduler-api -am -DskipITs -DskipTests=false 
-Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true 
-Dtest=AlertPluginInstanceServiceTest,AlertPluginInstanceControllerTest test`
   - `./mvnw -pl dolphinscheduler-api -am -DskipITs -DskipTests=false 
-Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true 
-Dtest=AlertPluginInstanceResourcePermissionCheckTest test`
   - `./mvnw -pl dolphinscheduler-dao -am -DskipITs -DskipTests=false 
-Dsurefire.failIfNoSpecifiedTests=false -Djacoco.skip=true 
-Dtest=AlertPluginInstanceMapperTest test`
   - `git diff --check`
   
   ## Pull Request Notice
   
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to