loftiest commented on PR #18273: URL: https://github.com/apache/dolphinscheduler/pull/18273#issuecomment-4516914820
Hi @SbloodyS , Thanks for the follow-up. I understand the concern about localParams and varPool coupling, but I respectfully hold a different view on the approach. The file parameter transfer feature has been documented in the official documentation for multiple versions, including the current 3.4.1: https://dolphinscheduler.apache.org/zh-cn/docs/3.4.1/guide/parameter/file-parameter. Users who follow the official guide have built their workflows based on this documented feature. When they upgrade to 3.4.1, their workflows silently break — and there is no warning, no deprecation notice, and no migration guide anywhere. Deleting a documented feature without any indication is incorrect and harmful to users who cannot upgrade safely. I agree a redesign would be valuable, but whether we restore or redesign, users need clear notice and a transition period. To reconcile both needs, I propose a phased approach: Phase 1 (this PR or a follow-up): Restore file transfer using the existing localParams with FILE type (consistent with current docs), but decouple it from varPool now — store remote paths in TaskExecutionContext instead of varPool, so the upload/download logic is already clean and independent. Phase 2 (separate PR/version): Introduce a new explicit file transfer configuration. Mark the old FILE-based localParams approach as @Deprecated with a prominent documentation notice, and remove it only in a subsequent version, giving users at least one full version cycle to migrate. The key principle: don't silently break documented features. Users need sufficient notice and a proper transition path. What do you think? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
