zhuxiangyi commented on PR #18312: URL: https://github.com/apache/dolphinscheduler/pull/18312#issuecomment-4610989410
> This repair way is not very good. The UI does not classify the result type of kill. If we want to do this, we should first discuss how to show this type to users in the UI, and then decide how to realize it. cc @ruanwenjun @SbloodyS Thanks for the review. I agree that exposing kill result types to users should be discussed separately. This PR does not intend to introduce a new user-visible kill state. The main problem here is that the worker currently treats any exception from `kill -0` as "process not alive", which can cause a false successful kill log while child processes are still alive. I can narrow this PR to only fix the false process-alive detection and avoid introducing a user-visible kill result classification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
