leocook commented on PR #18231:
URL:
https://github.com/apache/dolphinscheduler/pull/18231#issuecomment-4703886515
> This isn’t a good design, and it could lead to varpool bloat. Since it
isn’t declared in the task parameters, varpool is used declaratively; if no key
is declared, varpool shouldn’t be used. Also, in this case, why define an
additional p2? Can’t we just use p1 directly?
Good catch, thanks! I'll revert the varPool injection — agree it should stay
declarative.
Small note: the original #18074 is actually a same-name case (week_of_year
as IN), a bit different from my p1/p2 example — and you're right, p1 alone
works there.
That one fails on the ${} path though. Should I fix that here or split it
out, whatever works for you. I'll double-check on dev first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
