SbloodyS commented on code in PR #18349:
URL:
https://github.com/apache/dolphinscheduler/pull/18349#discussion_r3418472244
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkerGroupMapper.xml:
##########
@@ -28,6 +28,14 @@
from t_ds_worker_group
where name = #{name}
</select>
+ <select id="queryWorkerGroupByNames"
resultType="org.apache.dolphinscheduler.dao.entity.WorkerGroup">
+ select *
Review Comment:
You should avoid wild card select.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/EnvironmentWorkerGroupRelation.java:
##########
@@ -37,6 +37,11 @@ public class EnvironmentWorkerGroupRelation {
/**
* worker group id
*/
+ private Integer workerGroupId;
+
+ /**
+ * worker group name
+ */
Review Comment:
```suggestion
```
##########
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/WorkerGroupMapperTest.java:
##########
@@ -93,6 +94,21 @@ public void testQueryWorkerGroupByName() {
Assertions.assertEquals(0, workerGroups.size());
}
+ /**
+ * test query worker groups by names
+ */
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
