det101 commented on PR #18358: URL: https://github.com/apache/dolphinscheduler/pull/18358#issuecomment-4828229133
Good catch — you're right that logging poll errors alone doesn't cover the old `Watcher.onClose` fatal path, and without a FAILED/WARNFAILED timeout strategy `awaitJobCompletion()` could block indefinitely. I've added a bounded failure policy: after 3 consecutive GET poll failures (30s interval, ~90s total), the task fails and counts down the latch. A successful GET resets the counter, so transient errors don't immediately fail the task. This mirrors the intent of the old watcher close path when the API stays unreachable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
