qiuyanjun888 opened a new pull request, #18395:
URL: https://github.com/apache/dolphinscheduler/pull/18395

   ## Purpose
   
   Fix #17398
   
   Avoid leaking sensitive Dinky task information in task logs.
   
   ## Changes
   
   - Summarize Dinky task parameters instead of logging full task parameter 
JSON.
   - Summarize local variables by size and keys instead of logging values.
   - Avoid logging full Dinky API success response bodies; log status code and 
response length only.
   - Sanitize Dinky API error messages before logging or throwing task 
exceptions.
   - Avoid logging raw malformed Dinky API responses through JSON parse 
exceptions.
   - Extend `SensitiveDataConverter` coverage for common sensitive key/value 
formats.
   
   ## Tests
   
   - `./mvnw -pl 
dolphinscheduler-task-plugin/dolphinscheduler-task-api,dolphinscheduler-task-plugin/dolphinscheduler-task-dinky
 -am -DskipUT=false -DskipITs -DskipE2E -Dcheckstyle.skip -Dspotless.check.skip 
-Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false 
-Dtest=SensitiveDataConverterTest,DinkyLogSanitizerTest test`
   - `./mvnw -pl 
dolphinscheduler-task-plugin/dolphinscheduler-task-api,dolphinscheduler-task-plugin/dolphinscheduler-task-dinky
 -am spotless:apply`
   - `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to