qiuyanjun888 commented on PR #18416: URL: https://github.com/apache/dolphinscheduler/pull/18416#issuecomment-5018617967
Addressed the shutdown race described in https://github.com/apache/dolphinscheduler/pull/18416#issuecomment-4998227869 in commit [`8d9599e`](https://github.com/qiuyanjun888/dolphinscheduler/commit/8d9599e097e062e1409a3c31dc1eaea4efa955cf). - The transition to `DISCONNECTED` is now conditional and synchronized with `close()`, so a completed `STOPPED` transition cannot be overwritten and the disconnection callback is not invoked when close wins. - Added a latch-controlled regression test that holds an in-flight heartbeat update, completes `close()`, then returns a zero-row update result. Validation: - `JdbcRegistryServerTest`: 5 tests, 0 failures, 0 errors - module `spotless:check`: `BUILD SUCCESS` Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
