nikhiln64 commented on PR #18434:
URL:
https://github.com/apache/dolphinscheduler/pull/18434#issuecomment-5062173069
Thank you for the careful review @SbloodyS, all three points are addressed
and pushed.
The worker now treats the UI placeholder {} the same as an empty json field
through a shared isInlineJsonAbsent check, so the workflow from the issue
reaches the resource fallback. checkParameters follows the same rule, meaning
{} plus an attached resource is valid while {} alone is still rejected.
The UI json field validation in use-datax.ts now accepts an empty json
editor when a resource file is selected, so the UI and worker follow the same
source selection rules and the resource only case can actually be created
through the UI.
And there is a new DataxTask level regression test that runs handle() with
customConfig, json set to {} and a real temp resource file wired through
ResourceContext, asserting the generated job file contains the resource content
rather than the placeholder. The full module suite passes on JDK 8 with
spotless applied. The fresh CI run will need an approval when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
