richardmilles opened a new pull request, #18466: URL: https://github.com/apache/dolphinscheduler/pull/18466
## Was this PR generated or assisted by AI? YES. AI assistance was used for issue triage, drafting the change/test, and preparing the PR description. The fix logic and regression case were reviewed and verified against the reported failure mode (single quotes in DataX `-D` parameter values). ## Purpose of the pull request Fixes #18217 When DataX custom parameter values contain single quotes (for example `AND create_data > '2026-05-06 10:59:09'`), `DataxTask#addCustomParameters` embeds them into the shell command without escaping. That breaks shell quoting and can cause DataX to mis-parse arguments. ## Brief change log - Escape `'` as `'\''` in custom parameter values before building the DataX `-p` shell fragment - Treat null parameter values as empty strings - Add a regression unit test covering a value with embedded single quotes ## Verify this pull request This change added tests and can be verified as follows: - Added `DataxTaskTest#testBuildCommandEscapesSingleQuotesInCustomParameters` - Existing `DataxTaskTest#testHandleParamsMap` still covers quote-free values ## Pull Request Notice [Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
