liang-wenjie commented on PR #18548: URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-5336311451
I have manually reviewed the AI-assisted changes locally and will push the follow-up fixes shortly. The follow-up fixes have now been pushed in commit `f48a528139565d103d2b64e76af5c2e3f3996632`. The changes include: - preserving an existing `INTERVAL` trigger type when `triggerType` is omitted during update; - rejecting an explicit `null` trigger type; - validating interval expressions by requiring `repeat` and restricting `minute` / `second` to `0-59`; - adding service-layer and Quartz `SimpleTrigger` regression tests; - fixing the Spotless formatting issue in `SchedulerAPITest`. Local verification passed: - `SchedulerServiceTest`: 18 tests, 0 failures, 0 errors; - `QuartzSimpleTriggerBuilderTest`: 2 tests, 0 failures, 0 errors. Please take another look when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
