njnu-seafish commented on code in PR #18444:
URL:
https://github.com/apache/dolphinscheduler/pull/18444#discussion_r3811108907
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.xml:
##########
@@ -36,7 +50,7 @@
</select>
<select id="queryByHostAndStatus"
resultType="org.apache.dolphinscheduler.dao.entity.WorkflowInstance">
select
- <include refid="baseSql"/>
+ <include refid="listSql"/>
Review Comment:
> Add `WorkflowInstanceSummaryDO` and return `WorkflowInstanceSummaryDO`，
rather than return `WorkflowInstance` here.
ok. Add WorkflowInstanceSummaryDto and return WorkflowInstanceSummaryDto in
Mapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
