zixi0825 commented on PR #16863: URL: https://github.com/apache/dolphinscheduler/pull/16863#issuecomment-5404840932
Thanks for the detailed review. I've addressed all three points in commit `ae8128a438`: 1. **Persist and restore the DataVines execution ID**: `executeJob()` now calls `setAppIds()` immediately after the execute API returns the execution ID, so `AbstractRemoteTask.handle()` persists it. `trackApplicationStatus()` also restores `jobExecutionId` from the persisted app ID when the worker recovers, and a new test `trackApplicationStatusRestoresExecutionIdFromAppIds` covers the recovery path. 2. **Handle all terminal DataVines states**: Added `PAUSE`, `STOP` and `NEED_FAULT_TOLERANCE` to the polling switch (matching the DataVines `ExecutionStatus` enum), so they no longer fall into the default infinite-polling branch. Added parameterized tests for these states. 3. **Fail cancellation when the kill request fails**: `RequestUtils.killJobExecution()` now validates the HTTP status and the DataVines response and throws on failure; `cancelApplication()` propagates it as `TaskException`. The HTTP client also has bounded connect/socket/connection-request timeouts. Added tests `killJobExecutionInvalidHttpStatusThrowsException` and `killJobExecutionInvalidResponseThrowsException`. Local verification: `mvn -pl dolphinscheduler-task-plugin/dolphinscheduler-task-datavines clean test` passes (38 tests, 0 failures), and `spotless:check` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
