yan9651688 opened a new pull request, #18605:
URL: https://github.com/apache/dolphinscheduler/pull/18605

   ## Was this PR generated or assisted by AI?
   
   YES. The implementation and regression tests were AI-assisted. All changes 
were manually reviewed and verified.
   
   ## Purpose of the pull request
   
   Fix dependent tasks configured with **Task Name** set to `ALL`.
   
   The special `depTaskCode` value `-1` adds a second hyphen to the serialized 
key, so `DependentItem#fromKey()` currently rejects it as malformed. This 
change restores the negative sign while preserving the existing key format and 
behavior for regular task codes.
   
   Closes #18576
   
   ## Brief change log
   
   - Parse negative `depTaskCode` values from dependent-item keys.
   - Preserve the existing serialized key format.
   - Add regression coverage for positive task codes, workflow-level code `0`, 
`ALL` code `-1`, `Long.MIN_VALUE`, and malformed keys.
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - Added `DependentItemTest` for key round trips and malformed keys.
   - Run `./mvnw -pl dolphinscheduler-task-plugin/dolphinscheduler-task-api -am 
-Dtest=DependentItemTest -Dsurefire.failIfNoSpecifiedTests=false test`.
   - Run `./mvnw spotless:check`.
   
   ## Pull Request Notice
   [Pull Request 
Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
   
   If this pull request contains an incompatible change, it should also be 
added to `docs/docs/en/guide/upgrade/incompatible.md`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to