wcmolin opened a new issue, #18609:
URL: https://github.com/apache/dolphinscheduler/issues/18609

   ### Search before asking
   
   - [x] I searched the existing issues and found no issue describing this 
regression.
   
   ### What happened
   
   A query SQL task with **Send Email** enabled still executes successfully and 
builds the query result alert data, but no email is sent.
   
   The related API and implementation are still present:
   
   - `SqlParameters.sendEmail`
   - `SqlTask` creates and sets `TaskAlertInfo`
   - `AbstractTask.getNeedAlert()`
   - `AbstractTask.getTaskAlertInfo()`
   
   However, neither the current `3.4.2-release` branch nor the `dev` branch has 
a consumer that calls `getNeedAlert()` and sends the generated `TaskAlertInfo`.
   
   This appears to have happened during the task execution framework refactor 
in #16790. The old `WorkerTaskExecutor.sendAlertIfNeeded()` method was removed 
together with the old worker executor, but equivalent behavior was not added to 
the new task executor.
   
   The DSIP for that refactor, #16619, states that it should be compatible with 
the previous version. The incompatible-change documentation for #16790 only 
mentions executor thread configuration changes and does not mention removal of 
SQL query result emails.
   
   Could you please confirm whether SQL query result email notification was 
intentionally removed, or whether this is a regression in the new task executor?
   
   ### What you expected to happen
   
   When a query SQL task enables **Send Email**, DolphinScheduler should send 
the query result through the configured alert group, as it did before the 
executor refactor.
   
   If this capability has intentionally been deprecated, the UI option, 
`sendEmail` parameter, `TaskAlertInfo` generation code, and documentation 
should be removed or clearly marked as deprecated.
   
   ### How to reproduce
   
   1. Create a SQL task.
   2. Set SQL type to **Query**.
   3. Enable **Send Email** and configure a valid alert group.
   4. Run the workflow.
   5. Observe that the SQL query succeeds, but no query result email is sent 
and no SQL-task alert request is made.
   
   ### Version
   
   - 3.4.2
   - Current `3.4.2-release` source
   - Current `dev` source
   
   ### Related history
   
   - #12088 shows that SQL task query result email was supported in 3.0.0.
   - #12953 discusses extending SQL query result delivery beyond email, and 
describes email delivery as an existing capability.
   - #16619 / #16790 introduced the unified task executor where the final alert 
sending step disappeared.
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes, I am willing to submit a PR.
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's Code of Conduct.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to